Skip to content

Fixed issue with margin of SplitButton not being applied as margin correctly #3831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2025
Merged

Fixed issue with margin of SplitButton not being applied as margin correctly #3831

merged 1 commit into from
Apr 15, 2025

Conversation

JorisCleVR
Copy link
Contributor

When applying a margin to the SplitButton I got the following unexpected result:
image

With this PR the margins will be applied similar as they would for a normal button.

nicolaihenriksen
nicolaihenriksen approved these changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@nicolaihenriksen nicolaihenriksen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was a little curious about some edge cases, but it does seem to work as intended for the ones I tested. Nice work.

@Keboo Keboo added this to the 5.3.0 milestone Apr 15, 2025
@Keboo Keboo merged commit 9d09976 into MaterialDesignInXAML:master Apr 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keboo Keboo Keboo approved these changes

@nicolaihenriksen nicolaihenriksen nicolaihenriksen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@JorisCleVR @Keboo @nicolaihenriksen